This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[config-plugins] fix detecting application target #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
approved these changes
Feb 11, 2021
wkozyra95
approved these changes
Feb 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://exponent-internal.slack.com/archives/C010FFEQF0A/p1611929974023600
There are iOS projects that have multiple
BuildActionEntriesdefined in .xcscheme. Previously, we would take the first entry and useBlueprintNameas the target name. Unfortunately, this is not correct behavior. The application target is not always the first entry but looking for it is quite simple. Its buildable name ends with.app.How
Instead of taking the first entry, I added a
.findthat looks for an entry ending with.app.Test Plan
After merging
Bump @expo/config-plugins in eas-cli.